surgical YAML patches + twig sync audit (#529)#533
Draft
PolyphonyRequiem wants to merge 1 commit into
Draft
Conversation
- github-pr.yaml: add already_merged_emitter branch on merged/pr_url outputs (mirrors ado-pr.yaml:139-148); pr_url fallback changed to poll_status (same cleanup ado-pr.yaml uses — covers all non-merger exit paths uniformly) - close-out.yaml:43: | json → | tojson (correct Jinja2 filter) - plan-level.yaml/root-item-dispatch.yaml: validate_scope_verdict + scope_violation_files already fully wired; cross-check confirmed both fields present end-to-end with correct guards — no code change - Audit: twig state callers checked for post-state twig sync; 0 missing — all 3 real callers already compliant Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three surgical YAML patches surfaced from the 2026-05-28 squad fan-out (#522), plus a twig sync audit.
Closes #529.
Patches
Patch 1 —
github-pr.yaml: addalready_merged_emitteroutput branchMirrors
ado-pr.yaml:139-148. Thealready_merged_emitteragent existed at line 437 but was not referenced in the output block — callers receivedmerged=falseand an emptypr_urlon re-entry when the operator had already merged the PR through the GitHub UI.Changes (output block, lines 97-109):
merged: added{%- elif already_merged_emitter is defined -%}truebeforeclosed_unmerged_emitterpr_url: replacedclosed_unmerged_emitter.output.pr_urlfallback withpoll_status.output.pr_url— matching ado-pr.yaml's pattern and covering all non-merger exit paths uniformlyalready_merged_emitterandclosed_unmerged_emitteras valid non-merger exitsPatch 2 —
close-out.yaml:43:| json→| tojson| jsonis not a standard Jinja2 filter. Depending on conductor version it silently passes through the raw object repr or raises a template error. Correct filter is| tojson.Patch 3 —
plan-level.yaml/root-item-dispatch.yaml: bubble-up verified completeCross-checked both files.
validate_scope_verdictandscope_violation_filesare already present in both output blocks with correct Jinja guards ({%- if -%}in root-item-dispatch,{% if %}consistent with other plan-level fields). No code change required — wiring is end-to-end correct.Twig sync audit
Grepped all
.conductor/registry/workflows/*.yamlfortwig stateinvocations and checked the following ~10 lines fortwig sync.implement-merge-group.yamltwig state $validate.target_statepolyphony.yamlpolyphony.yamltwig state $validate.target_state --id ...root-item-dispatch.yamlroot-item-dispatch.yamlroot-item-dispatch.yamltwig state $validate.target_state --id ...All 3 actual
twig statecall sites already have a post-statetwig sync. No follow-up issues required.Lint
lint-github-pr.ps1: PASSlint-strict-undefined.ps1: PASS (15 workflows)lint-plan-level.ps1: PASStests/lint-sync-after-mutation.ps1: PASSConflict note
Wagner is on
squad/528-error-gate-migrationand may touchclose-out.yaml. This PR's edit is line 43 only (| json→| tojson). If a conflict surfaces, this PR rebases on the larger.